Hi Geert,

Thanks for the feedback.

Subject: Re: [PATCH v3 04/11] drivers: clk: renesas: r9a07g044-cpg: Add
USB clocks/resets

Hi Biju,

On Wed, Jun 30, 2021 at 9:30 AM Biju Das [off-list ref]
wrote:

quoted

Add clock/reset entries for USB PHY control, USB2.0 host and device.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v2->V3:
 * Added reset entries.

Thanks for the update!

quoted

--- a/drivers/clk/renesas/r9a07g044-cpg.c
+++ b/drivers/clk/renesas/r9a07g044-cpg.c

@@ -96,6 +96,14 @@ static struct rzg2l_mod_clk r9a07g044_mod_clks[] = {
                                0x52c, 0),
        DEF_MOD("dmac_pclk",    R9A07G044_DMAC_PCLK, CLK_P1_DIV2,
                                0x52c, 1),
+       DEF_MOD("usb0_host",    R9A07G044_USB_U2H0_HCLK,

R9A07G044_CLK_P1,

quoted

+                               0x578, 0),
+       DEF_MOD("usb1_host",    R9A07G044_USB_U2H1_HCLK,

R9A07G044_CLK_P1,

quoted

+                               0x578, 1),
+       DEF_MOD("usb0_device",  R9A07G044_USB_U2P_EXR_CPUCLK,

R9A07G044_CLK_P1,

quoted

+                               0x578, 2),

The names are not really used, but the lock list spreadsheet describes
this clock as the usb0 function clock, so perhaps "usb0_func" is more
appropriate?

OK. Will change it to "usb0_func".

Regards,
Biju

Apart from that:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
m68k.org

In personal conversations with technical people, I call myself a hacker.
But when I'm talking to journalists I just say "programmer" or something
like that.
                                -- Linus Torvalds