Re: [PATCH] clk: imx8: Unified initcall function
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Date: 2021-07-08 08:22:58
Also in:
linux-arm-kernel, lkml
Hello Rudy, On 08.07.21 10:15, Rudy Lo wrote:
It is better to use builtin_platform_driver initcall for clk driver rather then module_platform_driver, refer to clk-imx8qxp.c file.
Commit messages should spell out why the change is needed, so
why do you think it's better to revert
9a976cd278ea ("clk: imx8m: Support module build")?
Cheers,
Ahmad
quoted hunk ↗ jump to hunk
Signed-off-by: Rudy Lo <redacted> --- drivers/clk/imx/clk-imx8mm.c | 2 +- drivers/clk/imx/clk-imx8mn.c | 2 +- drivers/clk/imx/clk-imx8mp.c | 2 +- drivers/clk/imx/clk-imx8mq.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c index f1919fafb124..fa20b08e64f1 100644 --- a/drivers/clk/imx/clk-imx8mm.c +++ b/drivers/clk/imx/clk-imx8mm.c@@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = { .of_match_table = imx8mm_clk_of_match, }, }; -module_platform_driver(imx8mm_clk_driver); +builtin_platform_driver(imx8mm_clk_driver); MODULE_AUTHOR("Bai Ping <ping.bai@nxp.com>"); MODULE_DESCRIPTION("NXP i.MX8MM clock driver");diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c index 88f6630cd472..67b9ded112e4 100644 --- a/drivers/clk/imx/clk-imx8mn.c +++ b/drivers/clk/imx/clk-imx8mn.c@@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = { .of_match_table = imx8mn_clk_of_match, }, }; -module_platform_driver(imx8mn_clk_driver); +builtin_platform_driver(imx8mn_clk_driver); MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>"); MODULE_DESCRIPTION("NXP i.MX8MN clock driver");diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index 12837304545d..cdb40e61cef0 100644 --- a/drivers/clk/imx/clk-imx8mp.c +++ b/drivers/clk/imx/clk-imx8mp.c@@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = { .of_match_table = imx8mp_clk_of_match, }, }; -module_platform_driver(imx8mp_clk_driver); +builtin_platform_driver(imx8mp_clk_driver); MODULE_AUTHOR("Anson Huang <Anson.Huang@nxp.com>"); MODULE_DESCRIPTION("NXP i.MX8MP clock driver");diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c index c491bc9c61ce..54f17de30935 100644 --- a/drivers/clk/imx/clk-imx8mq.c +++ b/drivers/clk/imx/clk-imx8mq.c@@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = { .of_match_table = imx8mq_clk_of_match, }, }; -module_platform_driver(imx8mq_clk_driver); +builtin_platform_driver(imx8mq_clk_driver); MODULE_AUTHOR("Abel Vesa <abel.vesa@nxp.com>"); MODULE_DESCRIPTION("NXP i.MX8MQ clock driver");
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |