Re: [PATCH v4 22/24] drm/msm/dsi: remove temp data from global pll structure
From: John Stultz <hidden>
Date: 2021-06-11 19:16:31
Also in:
dri-devel, linux-arm-msm
On Fri, Jun 11, 2021 at 2:01 AM Dmitry Baryshkov [off-list ref] wrote:
Hi, On Fri, 11 Jun 2021 at 10:07, John Stultz [off-list ref] wrote:quoted
On Wed, Mar 31, 2021 at 3:58 AM Dmitry Baryshkov [off-list ref] wrote:quoted
The 7nm, 10nm and 14nm drivers would store interim data used during VCO/PLL rate setting in the global dsi_pll_Nnm structure. Move this data structures to the onstack storage. While we are at it, drop unused/static 'config' data, unused config fields, etc. Signed-off-by: Dmitry Baryshkov <redacted> Reviewed-by: Abhinav Kumar <redacted> Tested-by: Stephen Boyd <redacted> # on sc7180 lazorHey Dmitry, Just wanted to give you a heads up. Peter Collingbourne reported today that his db845c wasn't booting to display for him on his 4k monitor. It works fine on a 1080p screen, and while 4k isn't supported (yet?), normally the board should fall back to 1080p when connected to a 4k monitor. I was able to reproduce this myself and I see the errors below[1].It looks like I made a mistake testing these patches with the splash screen disabled. Stephen Boyd has proposed a fix few days ago (will be included into the 5.13). Could you check that it fixes the problem for you? https://lore.kernel.org/linux-arm-msm/20210608195519.125561-1-swboyd@chromium.org/ (local)
Ah! This does seem to fix it! Thank you so much for pointing it out! thanks -john