Thread (4 messages) 4 messages, 3 authors, 2021-06-25

Re: [PATCH] clk: tegra: clk-tegra124-dfll-fcpu: don't use devm functions for regulator

From: Stephen Boyd <sboyd@kernel.org>
Date: 2021-06-25 23:23:51
Also in: linux-tegra, lkml

Quoting Alexandru Ardelean (2021-06-24 01:47:37)
The purpose of the device-managed functions is to bind the life-time of an
object to that of a parent device object.

This is not the case for the 'vdd-cpu' regulator in this driver. A
reference is obtained via devm_regulator_get() and immediately released
with devm_regulator_put().

In this case, the usage of devm_ functions is slightly excessive, as the
un-managed versions of these functions is a little cleaner (and slightly
more economical in terms of allocation).

This change converts the devm_regulator_{get,put}() to
regulator_{get,put}() in the get_alignment_from_regulator() function of
this driver.

Signed-off-by: Alexandru Ardelean <redacted>
---
Applied to clk-next
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help