Thread (15 messages) 15 messages, 6 authors, 2021-06-20

Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

From: Sebastian Reichel <hidden>
Date: 2021-06-04 10:01:33
Also in: linux-devicetree, linux-pm, linux-rtc, linux-samsung-soc, lkml

Hi,

On Wed, Jun 02, 2021 at 03:06:09PM -0500, Rob Herring wrote:
On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote:
quoted
From: Krzysztof Kozlowski <krzk@kernel.org>

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 14577/77836 datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Iskren Chernev <iskren.chernev@gmail.com>

---

Changes since v1:
1. Remove the 'flags' variable.
2. Added ack.
3. Rebase - the bindings were converted to dtschema.
---
 .../devicetree/bindings/power/supply/maxim,max17040.yaml      | 2 +-
 drivers/power/supply/max17040_battery.c                       | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
Thanks, queued.

-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help