Hi Uwe,

On Fri, 2021-03-12 at 21:12 +0100, Uwe Kleine-König wrote:

Hello Nicolas,

quoted

+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2020 Nicolas Saenz Julienne [off-list ref]

2021?

Yes.

quoted

+ * For more information on Raspberry Pi's PoE hat see:
+ * https://www.raspberrypi.org/products/poe-hat/

Out of personal interest: Is this hat also able to power a RPi CM4?

I haven't tested it, and can't at the moment (no PoE injector available). But
the physical pin layout, and routing in CM4's IO board fits the hat. So I'd say
yes.

quoted

+ * Limitations:
+ *  - No disable bit, so a disabled PWM is simulated by duty_cycle 0
+ *  - Only normal polarity
+ *  - Fixed 12.5 kHz period
+ *
+ * The current period is completed when HW is reconfigured.
+ */

Other than that as mentioned in the previous round: This looks good,

Reviewed-by: Uwe Kleine-König <redacted>

Thanks!

What is your thought about how to get this series merged?
At least input, staging, armsoc, clk, reset anf firmware are touched. Do you
prepare a branch for merging in the relevant trees (once you have all the
necessary Acks)?

As per Linusw suggestion I'll send a pull request myself into the SoC tree and
hope for the best. :)

Regards,
Nicolas