Re: [PATCH v2 10/17] gpio: support ROHM BD71815 GPOs

Hi Bartosz,

On Tue, 2021-01-19 at 12:07 +0100, Bartosz Golaszewski wrote:

On Tue, Jan 19, 2021 at 8:23 AM Matti Vaittinen
[off-list ref] wrote:

quoted

Support GPO(s) found from ROHM BD71815 power management IC. The IC
has two
GPO pins but only one is properly documented in data-sheet. The
driver
exposes by default only the documented GPO. The second GPO is
connected to
E5 pin and is marked as GND in data-sheet. Control for this
undocumented
pin can be enabled using a special DT property.

This driver is derived from work by Peter Yang <
yanglsh@embest-tech.com>
although not so much of original is left.

Signed-off-by: Matti Vaittinen <redacted>

Hi Matti,

looks great, just a couple nits.

Thanks for the review! I'll store your finsings and fix them when I
respin this. I think all of your points were valid. As I know this is
largish series (and as I know I accidentally sent first 10 v2 patches
to all recipients no matter what subsystem was impacted) I'll wait for
a while before resending (at least a week). Besides I don't expect the
dependencies to be merged before next kernel release so this is not
urgent :)

- but thanks!

Br,
	Matti