Thread (11 messages) 11 messages, 5 authors, 2016-08-22

Re: [PATCH 3/3] MIPS: TXx9: Convert to Common Clock Framework

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-08-22 08:46:26
Also in: linux-mips, linux-spi, linux-watchdog

Hi Stephen,

On Fri, Aug 19, 2016 at 9:17 PM, Stephen Boyd [off-list ref] wrote:
On 08/18, Geert Uytterhoeven wrote:
quoted
diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips/txx9/generic/setup.c
index ada92db92f87d91a..2fdbcf91b2cc472c 100644
--- a/arch/mips/txx9/generic/setup.c
+++ b/arch/mips/txx9/generic/setup.c
@@ -560,8 +527,39 @@ void __init plat_time_init(void)
      txx9_board_vec->time_init();
 }

+static void txx9_clk_init(void)
+{
+     struct clk *clk;
+     int error;
+
+     clk = clk_register_fixed_rate(NULL, "gbus", NULL, 0, txx9_gbus_clock);
Can we use the clk_hw_*() based variants instead please?
Yes we can.

BTW, is it intentional that clk_hw_register_clkdev() doesn't detect errors
from a previous registration call, like clk_register_clkdev() does?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help