Thread (7 messages) 7 messages, 2 authors, 2015-07-16
STALE4016d

[PATCH 1/4] clk: ti: Check kzalloc() for failures

From: Stephen Boyd <hidden>
Date: 2015-07-15 20:08:24
Also in: lkml
Subsystem: common clk framework, the rest, ti clock driver · Maintainers: Michael Turquette, Stephen Boyd, Linus Torvalds, Tero Kristo

smatch reports a failure to check kzalloc() here:

drivers/clk/ti/clk.c:232
omap2_clk_provider_init() error: potential null dereference 'io'.
(kzalloc returns null)

Check for an allocation failure and return -ENOMEM.

Cc: Tero Kristo <redacted>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/clk/ti/clk.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/clk/ti/clk.c b/drivers/clk/ti/clk.c
index 7e037c45e459..931b44118bdf 100644
--- a/drivers/clk/ti/clk.c
+++ b/drivers/clk/ti/clk.c
@@ -228,6 +228,8 @@ int __init omap2_clk_provider_init(struct device_node *parent, int index,
 	clocks_node_ptr[index] = clocks;
 
 	io = kzalloc(sizeof(*io), GFP_KERNEL);
+	if (!io)
+		return -ENOMEM;
 
 	io->regmap = syscon;
 	io->mem = mem;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help