Re: [PATCH] cifs: Constify static struct genl_ops
From: Steve French <smfrench@gmail.com>
Date: 2021-06-05 20:48:47
Also in:
lkml
merged into cifs-2.6.git for-next On Wed, May 26, 2021 at 4:06 PM Rikard Falkeborn [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The only usage of cifs_genl_ops[] is to assign its address to the ops field in the genl_family struct, which is a pointer to const. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <redacted> --- fs/cifs/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/cifs/netlink.c b/fs/cifs/netlink.c index 5aaabe4cc0a7..291cb606f149 100644 --- a/fs/cifs/netlink.c +++ b/fs/cifs/netlink.c@@ -30,7 +30,7 @@ static const struct nla_policy cifs_genl_policy[CIFS_GENL_ATTR_MAX + 1] = { [CIFS_GENL_ATTR_SWN_RESOURCE_NAME] = { .type = NLA_STRING}, }; -static struct genl_ops cifs_genl_ops[] = { +static const struct genl_ops cifs_genl_ops[] = { { .cmd = CIFS_GENL_CMD_SWN_NOTIFY, .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP, --2.31.1
-- Thanks, Steve