Thread (6 messages) 6 messages, 3 authors, 2021-02-25

Re: [PATCH] cifs: use discard iterator to discard unneeded network data more efficiently

From: Aurélien Aptel <hidden>
Date: 2021-02-04 10:31:45
Also in: linux-fsdevel

Steve French [off-list ref] writes:
+ssize_t
+cifs_discard_from_socket(struct TCP_Server_Info *server, size_t to_read)
+{
+	struct msghdr smb_msg;
+
+	iov_iter_discard(&smb_msg.msg_iter, READ, to_read);
+
+	return cifs_readv_from_socket(server, &smb_msg);
+}
+
Shouldn't smb_msg be initialized to zeroes? Looking around this needs to
be done for cifs_read_from_socket() and cifs_read_page_from_socket() too.

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help