Re: [PATCH v5 1/2] dt-bindings: can: m_can: add ti,am62-mcan compatible
From: sashiko-bot@kernel.org
Date: 2026-09-12 21:37:13
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incorrect YAML indentation for the `items` sequence violates the kernel's yamllint rules, breaking `make dt_binding_check`. -- commit ce14f1f5cb441a60c48d5a3b96ea09ddcd2c9e74 Author: Kendall Willis [off-list ref] dt-bindings: can: m_can: add ti,am62-mcan compatible This commit adds the ti,am62-mcan compatible string to the Bosch M_CAN device tree bindings. It updates the schema to allow the new TI compatible as a fallback to the generic Bosch compatible.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml@@ -16,7 +16,11 @@ allOf: properties: compatible: - const: bosch,m_can + oneOf: + - const: bosch,m_can + - items: + - const: ti,am62-mcan + - const: bosch,m_can
[Severity: Low] Does this indentation in properties.compatible violate the yamllint rules for device tree bindings? The configuration in Documentation/devicetree/bindings/.yamllint enforces an indent-sequences rule with a 2-space indentation requirement. It looks like the sequence items under the items keyword are placed at 8 spaces, which matches the column start of the items keyword rather than being indented to 10 spaces. Could this formatting violation cause make dt_binding_check to fail during the build? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260912-temp-v5-0-2e3201c02109@ti.com?part=1