Re: [PATCH v3 2/3] can: m_can: Batch FIFO reads during CAN receive
From: Matt Kline <hidden>
Date: 2021-09-27 08:25:10
From: Matt Kline <hidden>
Date: 2021-09-27 08:25:10
Hey Aswath, Definitely looks like a silly mistake on my part, thanks for sending fixes! Apologies for the slow response; I was out for the past week or so. Best, Matt On Thu, Sep 16, 2021 at 05:34:45PM +0530, Aswath Govindraju wrote:
Hi Matt, Marc, While reading multiple register fields and calling iomap_read_fifo() in m_can_platform.c is causing an issue. In iomap_read_fifo(), ioread32_rep() is being used for reading. ioread32_rep reads() from the same source address for val_count times. This is not the intended behavior here. The source address also needs to be shifted along with the destination address. Is a fix required in iomap_read_fifo() ? Thanks, Aswath