Thread (12 messages) 12 messages, 2 authors, 2021-08-14

Re: [RFC PATCH v4 3/4] iplink_can: print brp and dbrp bittiming variables

From: Vincent MAILHOL <hidden>
Date: 2021-07-09 12:17:51

On Wed. 7 Jul 2021 at 18:33, Stefan Mätje [off-list ref] wrote:
Am Dienstag, den 29.06.2021, 00:44 +0900 schrieb Vincent Mailhol:
quoted
Report the value of the bit-rate prescaler (brp) for both the nominal
and the data bittiming.

Currently, only the constant brp values (brp_{min,max,inc}) are being
reported. Also, brp is the only member of struct can_bittiming not
being reported.

Although brp is not used as an input for bittiming calculation, it
makes sense to output it.

Signed-off-by: Vincent Mailhol <redacted>
I think it is a good idea to display both brp and dbrp values because it makes
the displayed bitrate settings complete. Even if it could be calculated from the
displayed clock and tq values.
Your remark is true. I also realized that BRP can be calculated
from the other parameters but because I am lazy, I like to have
it reported so I wrote this patch. I will add a note in the patch
comments to reflect that this value could be calculated by hand.


Yours sincerely,
Vincent
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help