On Thu, 24 Jun 2021 12:50:05 +0200, Marc Kleine-Budde wrote:

On 24.06.2021 05:19:54, Kurt Van Dijck wrote:

quoted

Signed-off-by: Kurt Van Dijck <redacted>
---
+	}, {
+		.bittiming_const = {
+			.name = "mcan",

This is for mcan > v3.1

I don't have any earlier.
Can I just solve by putting "mcan-v3.1+"?

quoted

+			.tseg1_min = 1,
+			.tseg1_max = 256,
+			.tseg2_min = 1,

I just re-chcked the datasheet, and tseg{1,2} min are actually 2.

Will adapt.
I clearly didn't pay enough attention to the lower limits.

quoted

+			.tseg2_max = 128,
+			.sjw_max = 128,
+			.brp_min = 1,
+			.brp_max = 512,
+			.brp_inc = 1,
+		},
+		.ref_clk = {
+			{ .clk = 40000000, },
+		},
+		.printf_btr = printf_btr_mcan,
 	},
 };

Marc

btw, I just noticed I already have can-utils in my github account, I'll
create a Merge-Request for this V2 too, if you like.

Kurt