Re: [PATCH 1/5] can: flexcan: add platform data for ColdFire
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-06-09 08:14:58
Also in:
linux-m68k
Hi Angelo, On Tue, Jun 8, 2021 at 10:46 PM Angelo Dureghello [off-list ref] wrote:
Add platform data object for ColdFire architecture. Signed-off-by: Angelo Dureghello <redacted>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/include/linux/platform_data/flexcan-mcf.h@@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Flexcan options for ColdFire family + * + * Copyright (C) 2021 Angelo Dureghello <angelo@kernel-space.org> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _PLAT_FLEXCAN_MCF_H +#define _PLAT_FLEXCAN_MCF_H + +struct mcf_flexcan_platform_data { + int stop_mode;
Unused?
+ int clk_src; + int clock_frequency;
Might be worthwhile to match the types used in the driver (i.e. u8 and u32).
+ bool big_endian; +}; + +#endif /* _PLAT_FLEXCAN_MCF_H */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds