Thread (1 message) 1 message, 1 author, 2021-03-04

Re: mcp251x hangs during ifup

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-03-04 00:24:01

Possibly related (same subject, not in this thread)

On 03.03.2021 10:00:47, ukrfoil.com, Cтудиопак Украина, Восточный регион wrote:
this with the IRQ_TYPE_EDGE_FALLING value
quoted
That looks good, the IRQ is not shared. Can you test again with
IRQ_TYPE_EDGE_FALLING in the DT instead of IRQ_TYPE_LEVEL_LOW?
Doh! Need more coffee.

Of course I mean try with IRQ_TYPE_LEVEL_LOW and check if the unmodified
mcp2515 driver with disable_irq() does work then.
quoted
| can0: can@0 {
|       reg = <0>;
|       compatible = "microchip,mcp2515";
|       pinctrl-names = "default";
|       pinctrl-0 = <&can0_pin_irq>;
|       interrupt-parent = <&pio>;
|       interrupts = <6 8 IRQ_TYPE_EDGE_FALLING>;

You better use IRQ_TYPE_LEVEL_LOW instead of IRQ_TYPE_EDGE_FALLING, but
that's unrelated to this problem.

|       clocks = <&can0_osc_fixed>;
|       spi-max-frequency = <10000000>;
|       gpio-controller;
|       gpio-cells = <2>;
|       status = "okay";
| };
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help