Thread (18 messages) 18 messages, 6 authors, 2021-03-29

Re: [kbuild-all] Re: include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_536' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(struct canfd_frame, len) || offsetof(struct can_frame, data) != offsetof(struc...

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2021-03-23 07:46:54
Also in: lkml, oe-kbuild-all

On 23.03.21 08:34, Marc Kleine-Budde wrote:
On 23.03.2021 10:54:40, Rong Chen wrote:
quoted
I tried arm-linux-gnueabi (gcc version 10.2.0) and the problem still
exists, btw we prefer to not use the latest gcc compiler to avoid
false positives.
FWIW:

I'm using latest debian arm compiler and the BUILD_BUG never triggered.
gcc version 10.2.1 20210110 (Debian 10.2.1-6)
Thanks Marc!

IMO we facing a compiler problem here - and we should be very happy that 
the BUILD_BUG_ON() triggered an issue after years of silence.

I do not have a good feeling about what kind of strange effects this 
compiler issue might have in other code of other projects.

So I would explicitly suggest NOT to change the af_can.c code to work 
around this compiler issue.

Let the gcc people fix their product and let them thank all of us for 
detecting it.

Regards,
Oliver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help