Thread (5 messages) 5 messages, 2 authors, 2021-02-26

Re: can, tcan4x5x: look to merge rpi support into rpi kernel tree

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-02-26 12:28:56

Possibly related (same subject, not in this thread)

On 2/26/21 1:27 PM, Torin Cooper-Bennun wrote:
On Tue, Feb 16, 2021 at 01:32:35PM +0100, Marc Kleine-Budde wrote:
quoted
If the number of blank frames equals the number of missing frames, then
have a look where the message RAM is initialized:
This is the case, but it occurred over a matter of seconds (the frames
were only being sent about twice a second). I've finally got some time
to investigate, so I'll try to find out what's going on.
quoted
    https://elixir.bootlin.com/linux/latest/source/drivers/net/can/m_can/tcan4x5x.c#L335

Oh! This doesn't look right :(

I think it's a bad idea to first bring the chip into normal mode and
then initialize the RAM.
I'm unsure whether this caused it, but needless to say, this is bad in
any case!
Feel free to send patches. :D

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help