Thread (11 messages) 11 messages, 2 authors, 2021-02-24

Re: [PATCH v1 3/5] can: netlink: move '=' operators back to previous line (checkpatch fix)

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-02-23 19:50:54

On 24.02.2021 01:28:50, Vincent Mailhol wrote:
[...]
quoted hunk ↗ jump to hunk
--- a/drivers/net/can/dev/netlink.c
+++ b/drivers/net/can/dev/netlink.c
@@ -8,20 +8,18 @@
 #include <net/rtnetlink.h>
 
 static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
-	[IFLA_CAN_STATE]	= { .type = NLA_U32 },
-	[IFLA_CAN_CTRLMODE]	= { .len = sizeof(struct can_ctrlmode) },
-	[IFLA_CAN_RESTART_MS]	= { .type = NLA_U32 },
-	[IFLA_CAN_RESTART]	= { .type = NLA_U32 },
-	[IFLA_CAN_BITTIMING]	= { .len = sizeof(struct can_bittiming) },
-	[IFLA_CAN_BITTIMING_CONST]
-				= { .len = sizeof(struct can_bittiming_const) },
-	[IFLA_CAN_CLOCK]	= { .len = sizeof(struct can_clock) },
-	[IFLA_CAN_BERR_COUNTER]	= { .len = sizeof(struct can_berr_counter) },
-	[IFLA_CAN_DATA_BITTIMING]
-				= { .len = sizeof(struct can_bittiming) },
-	[IFLA_CAN_DATA_BITTIMING_CONST]
-				= { .len = sizeof(struct can_bittiming_const) },
-	[IFLA_CAN_TERMINATION]	= { .type = NLA_U16 },
+	[IFLA_CAN_STATE]		= { .type = NLA_U32 },
+	[IFLA_CAN_CTRLMODE]		= { .len = sizeof(struct can_ctrlmode) },
+	[IFLA_CAN_RESTART_MS]		= { .type = NLA_U32 },
+	[IFLA_CAN_RESTART]		= { .type = NLA_U32 },
+	[IFLA_CAN_BITTIMING]		= { .len = sizeof(struct can_bittiming) },
+	[IFLA_CAN_BITTIMING_CONST]	= { .len = sizeof(struct can_bittiming_const) },
+	[IFLA_CAN_CLOCK]		= { .len = sizeof(struct can_clock) },
+	[IFLA_CAN_BERR_COUNTER]		= { .len = sizeof(struct can_berr_counter) },
+	[IFLA_CAN_DATA_BITTIMING]	= { .len = sizeof(struct can_bittiming) },
+	[IFLA_CAN_DATA_BITTIMING_CONST]	= { .len = sizeof(struct can_bittiming_const) },
+	[IFLA_CAN_TERMINATION]		= { .type = NLA_U16 },
+	[IFLA_CAN_TERMINATION]		= { .type = NLA_U16 },
You doubled the last entry by mistake.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help