Re: [net-next 10/13] can: length: can_skb_get_frame_len(): introduce... | linux-can

[net-next 00/13] can: dev: cleanup and add CAN frame length handling support · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 02/13] can: dev: move driver related infrastructure into separate subdir · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 03/13] can: dev: move bittiming related code into seperate file · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 01/13] MAINTAINERS: CAN network layer: add missing header file can-ml.h · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 05/13] can: dev: move skb related into seperate file · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
Re: [net-next 05/13] can: dev: move skb related into seperate file · Vincent MAILHOL <hidden> · 2021-01-10
Re: [net-next 05/13] can: dev: move skb related into seperate file · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
[net-next 08/13] can: length: can_fd_len2dlc(): simplify length calculcation · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 07/13] can: length: convert to kernel coding style · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 09/13] can: length: canfd_sanitize_len(): add function to sanitize CAN-FD data length · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 11/13] can: dev: extend struct can_skb_priv to hold CAN frame length · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
Re: [net-next 11/13] can: dev: extend struct can_skb_priv to hold CAN frame length · Vincent MAILHOL <hidden> · 2021-01-10
Re: [net-next 11/13] can: dev: extend struct can_skb_priv to hold CAN frame length · Vincent MAILHOL <hidden> · 2021-01-10
[PATCH] can: dev: extend can_put_echo_skb() to handle frame_len · Vincent Mailhol <hidden> · 2021-01-11
Re: [PATCH] can: dev: extend can_put_echo_skb() to handle frame_len · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
Re: [PATCH] can: dev: extend can_put_echo_skb() to handle frame_len · Vincent MAILHOL <hidden> · 2021-01-11
Re: [PATCH] can: dev: extend can_put_echo_skb() to handle frame_len · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
[PATCH v2] can: dev: can_put_echo_skb(): extend to store can frame length · Vincent Mailhol <hidden> · 2021-01-11
Re: [PATCH v2] can: dev: can_put_echo_skb(): extend to store can frame length · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
Re: [PATCH v2] can: dev: can_put_echo_skb(): extend to store can frame length · Vincent MAILHOL <hidden> · 2021-01-11
Re: [PATCH] can: dev: extend can_put_echo_skb() to handle frame_len · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
Re: [net-next 11/13] can: dev: extend struct can_skb_priv to hold CAN frame length · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
Re: [net-next 11/13] can: dev: extend struct can_skb_priv to hold CAN frame length · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
[net-next 04/13] can: dev: move length related code into seperate file · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
Re: [net-next 04/13] can: dev: move length related code into seperate file · Oliver Hartkopp <socketcan@hartkopp.net> · 2021-01-11
Re: [net-next 04/13] can: dev: move length related code into seperate file · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
[net-next 06/13] can: dev: move netlink related code into seperate file · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
Re: [net-next 06/13] can: dev: move netlink related code into seperate file · Vincent MAILHOL <hidden> · 2021-01-10
Re: [net-next 06/13] can: dev: move netlink related code into seperate file · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
[net-next 10/13] can: length: can_skb_get_frame_len(): introduce function to get data length of frame in data link layer · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
Re: [net-next 10/13] can: length: can_skb_get_frame_len(): introduce function to get data length of frame in data link layer · Vincent MAILHOL <hidden> · 2021-01-10
Re: [net-next 10/13] can: length: can_skb_get_frame_len(): introduce function to get data length of frame in data link layer · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
[net-next 12/13] can: dev: can_get_echo_skb(): extend to return can frame length · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
[net-next 13/13] can: dev: can_rx_offload_get_echo_skb(): extend to return can frame length · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-09
Re: [net-next 00/13] can: dev: cleanup and add CAN frame length handling support · Vincent MAILHOL <hidden> · 2021-01-10
Re: [net-next 00/13] can: dev: cleanup and add CAN frame length handling support · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
Re: [net-next 00/13] can: dev: cleanup and add CAN frame length handling support · Vincent MAILHOL <hidden> · 2021-01-11
Re: [net-next 00/13] can: dev: cleanup and add CAN frame length handling support · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11
Re: [net-next 00/13] can: dev: cleanup and add CAN frame length handling support · Vincent MAILHOL <hidden> · 2021-01-11
Re: [net-next 00/13] can: dev: cleanup and add CAN frame length handling support · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-01-11

Re: [net-next 10/13] can: length: can_skb_get_frame_len(): introduce function to get data length of frame in data link layer

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-01-11 08:13:17

On 1/10/21 4:32 AM, Vincent MAILHOL wrote:
[...]

quoted

+/*
+ * Maximum size of a CAN-FD frame (rough estimation because
+ * ES58X_SFF_BYTES() and ES58X_EFF_BYTES() macros are using the
+ * constant values for Classical CAN, not CAN-FD).
+ */

/*
 * Maximum size of a CAN-FD frame
 * (rounded up and ignoring bitstuffing)
 */
It is a leftover from my original comment. Does not apply anymore
thanks to your newly introduced CANFD_FRAME_OVERHEAD_EFF macro.

Fixed.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachments

signature.asc [application/pgp-signature] 488 bytes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help