Thread (23 messages) 23 messages, 4 authors, 2018-03-16

Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2018-03-13 17:56:41
Also in: lkml

On 03/13/2018 06:53 PM, Jakob Unterwurzacher wrote:
On 13.03.18 18:44, Marc Kleine-Budde wrote:
quoted
On 03/13/2018 06:35 PM, Jakob Unterwurzacher wrote:

[...]

Please mark all multibyte values going over the USB as either le or be.
This is documented in can_ucan_protocol.rst,

     All multi-byte integers are encoded as Little Endian.

but it's probably worth mentioning here as well.
Yes, but in the code, use "__le16" and "__le32" instead of "u16" and "u32"

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help