On 01/18/2017 06:48 PM, Oliver Hartkopp wrote:

Just a small issue in the commit message:

On 01/18/2017 03:59 PM, Marc Kleine-Budde wrote:

quoted

From: Oliver Hartkopp <socketcan@hartkopp.net>

This patch adds a netlink interface to configure the CAN bus termination of
CAN interfaces.

Inside the driver an array of supported termination values is defined:

const u16 drvname_termination[] = { 60, 120, CAN_TERMINATION_DISABLED };

struct drvname_priv *priv;
priv = netdev_priv(dev);

priv->termination_const = &drvname_termination;

This has to be:
priv->termination_const = drvname_termination;

or we will get a incompatible pointer warning.

Found the issue by adding the documentation PoC in usb_8dev for testing:

Fixed.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |