Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-02-29 09:54:19
Also in:
linux-arm-kernel, linux-devicetree, linux-renesas-soc, netdev
Possibly related (same subject, not in this thread)
- 2016-02-29 · RE: [PATCH 1/2] can: rcar_can: Add r8a7795 support · Ramesh Shanmugasundaram <hidden>
- 2016-02-29 · Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support · Marc Kleine-Budde <mkl@pengutronix.de>
- 2016-02-29 · Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support · Marc Kleine-Budde <mkl@pengutronix.de>
- 2016-02-29 · Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support · Marc Kleine-Budde <mkl@pengutronix.de>
- 2016-02-29 · RE: [PATCH 1/2] can: rcar_can: Add r8a7795 support · Ramesh Shanmugasundaram <hidden>
Hi Ramesh, On Mon, Feb 29, 2016 at 10:21 AM, Ramesh Shanmugasundaram [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/net/can/rcar_can.c +++ b/drivers/net/can/rcar_can.c@@ -808,6 +808,10 @@ static int rcar_can_probe(struct platform_device *pdev) priv->regs = addr; priv->clock_select = clock_select; priv->can.clock.freq = clk_get_rate(priv->can_clk); + + /* Use the rounded clock value (nearest kHz) */ + priv->can.clock.freq = 1000 * DIV_ROUND_UP(priv->can.clock.freq, 1000);
The comment and the implementation don't match.
To get the nearest kHz, you have to useDIV_ROUND_CLOSEST().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds