Re: [PATCH v2] can: c_can: add xceiver enable/disable support
From: Michael Grzeschik <hidden>
Date: 2016-01-20 16:46:50
Also in:
lkml, netdev
Possibly related (same subject, not in this thread)
- 2016-01-20 · Re: [PATCH v2] can: c_can: add xceiver enable/disable support · Kurt Van Dijck <hidden>
- 2016-01-20 · Re: [PATCH v2] can: c_can: add xceiver enable/disable support · Markus Pargmann <hidden>
- 2016-01-20 · Re: [PATCH v2] can: c_can: add xceiver enable/disable support · Marc Kleine-Budde <mkl@pengutronix.de>
- 2016-01-20 · Re: [PATCH v2] can: c_can: add xceiver enable/disable support · Markus Pargmann <hidden>
- 2016-01-20 · [PATCH v2] can: c_can: add xceiver enable/disable support · Michael Grzeschik <hidden>
Hi, On Wed, Jan 20, 2016 at 05:19:18PM +0100, Bjørn Mork wrote:
Michael Grzeschik [off-list ref] writes:quoted
@@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev) */ pinctrl_pm_select_sleep_state(dev->dev.parent); + priv->reg_xceiver = devm_regulator_get(priv->device, "xceiver"); + if (IS_ERR(priv->reg_xceiver)) + return PTR_ERR(priv->reg_xceiver); + c_can_pm_runtime_enable(priv); dev->flags |= IFF_ECHO; /* we support local echo */Do you really want to leave priv->reg_xceiver pointing to an ERR_PTR in case of error?
No, therefore the priv->reg_xceiver will be returned in case of error. This codepath is called once on device registration. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |