Re: [PATCH v2 02/12] ARM: dts: DRA7: Add DCAN nodes
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2014-09-09 15:06:26
Also in:
linux-omap
On 09/09/2014 05:04 PM, Marc Kleine-Budde wrote:
On 09/09/2014 04:55 PM, Roger Quadros wrote:quoted
The SoC supports 2 DCAN nodes. Add them.I think you should put the device-tree ml for DT related patches on Cc.quoted
Signed-off-by: Roger Quadros <redacted> --- arch/arm/boot/dts/dra7.dtsi | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 370009e..09d5739 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi@@ -34,6 +34,8 @@ serial3 = &uart4; serial4 = &uart5; serial5 = &uart6; + d_can0 = &dcan1; + d_can1 = &dcan2; }; timer {@@ -1267,6 +1269,34 @@ ti,irqs-skip = <10 133 139 140>; ti,irqs-safe-map = <0>; }; + + dcan1: can@481cc000 { + compatible = "bosch,d_can"; + ti,hwmods = "dcan1"; + reg = <0x4ae3c000 0x2000>, + <0x558 0x4>; /* index to RAMINIT reg within syscon */Putting the offset within the syscon here doesn't look good.quoted
+ ti,raminit-syscon = <&dra7_ctrl_core>;Why not add it as a second parameter to the ti,raminit-syscon instead?
./drivers/power/reset/keystone-reset.c does this. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachments
- signature.asc [application/pgp-signature] 181 bytes