Thread (22 messages) 22 messages, 4 authors, 2014-07-03

Re: [PATCH 1/3] can: m_can: add Bosch M_CAN controller support

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2014-07-01 10:33:20
Also in: linux-devicetree, netdev

On 06/27/2014 12:00 PM, Dong Aisheng wrote:
+static int m_can_close(struct net_device *dev)
+{
+	struct m_can_priv *priv = netdev_priv(dev);
+
+	netif_stop_queue(dev);
+	napi_disable(&priv->napi);
+	m_can_stop(dev);
+	free_irq(dev->irq, dev);
+	close_candev(dev);
+	can_led_event(dev, CAN_LED_EVENT_STOP);
You forgot to turn of the clock.
+
+	return 0;
+}
Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help