Thread (2 messages) 2 messages, 2 authors, 2013-02-04

[PATCH] slcand: fix build warnings

From: <hidden>
Date: 2013-02-04 09:10:52
Subsystem: the rest · Maintainer: Linus Torvalds

From: Yegor Yefremov <redacted>

Remove unused variable name.

Fix FILE pointer check (fopen() returns a pointer not an integer).

Signed-off-by: Yegor Yefremov <redacted>
---
 slcand.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/slcand.c b/slcand.c
index 2353c99..807ffaa 100644
--- a/slcand.c
+++ b/slcand.c
@@ -95,7 +95,7 @@ static void child_handler (int signum)
 	}
 }
 
-static void daemonize (const char *lockfile, char *tty, char *name)
+static void daemonize (const char *lockfile, char *tty)
 {
 	pid_t pid, sid, parent;
 	int lfp = -1;
@@ -182,7 +182,7 @@ static void daemonize (const char *lockfile, char *tty, char *name)
 	}
 
 	pFile = fopen (pidfile,"w");
-	if (pFile < 0)
+	if (pFile == NULL)
 	{
 		syslog (LOG_ERR, "unable to create pid file %s, code=%d (%s)",
 			pidfile, errno, strerror (errno));
@@ -243,7 +243,7 @@ int main (int argc, char *argv[])
 	syslog (LOG_INFO, "starting on TTY device %s", ttypath);
 
 	/* Daemonize */
-	daemonize ("/var/lock/" DAEMON_NAME, tty, name);
+	daemonize ("/var/lock/" DAEMON_NAME, tty);
 
 	/* Now we are a daemon -- do the work for which we were paid */
 	int fd;
-- 
1.7.7
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help