Thread (18 messages) 18 messages, 4 authors, 2012-12-18

Re: [PATCH 1/9] can: add tx/rx LED trigger support

From: Fabio Baltieri <hidden>
Date: 2012-12-17 21:42:35
Also in: lkml

On Mon, Dec 17, 2012 at 09:20:57PM +0100, "Bernd Krumböck" wrote:
quoted
If you think it's useful for USB controller, just tell me or modify the
driver by yourself!  As you see the patch is really easy.
At least it is useful for the usb_8dev driver. I'll write a patch.

Photo of the device:
http://www.8devices.com/product/2/usb2can
Sure that it's needed?  That status LED is probably controlled directly
by the firmware itself.  Anyway I think it makes sense to support all
the mainline drivers and I'm really happy if you test the patch on
your hardware!

My only suggestion is to keep the LED support on a separate patch from
the "add driver" one.

Cheers,
Fabio

-- 
Fabio Baltieri
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help