Thread (8 messages) 8 messages, 3 authors, 2012-08-10

AW: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing

From: Schmitt, Sven (EVM/8) <hidden>
Date: 2012-08-10 08:23:32

Right.

Thanks.
Sven

-----Ursprüngliche Nachricht-----
Von: Marc Kleine-Budde [mailto:mkl@pengutronix.de] 
Gesendet: Freitag, 10. August 2012 10:21
An: Schmitt, Sven (EVM/8)
Cc: unlisted-recipients; yegor_sub1@visionsystems.de; linux-can@vger.kernel.org
Betreff: Re: AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing

On 08/09/2012 02:46 PM, Schmitt, Sven (EVM/8) wrote:
quoted hunk ↗ jump to hunk
Second try:

Signed-off-by: Sven Schmitt <redacted>
--- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
+++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
@@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
 	priv = netdev_priv(dev);
 
 	dev->irq = res_irq->start;
-	priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
IRQF_SHARED);
+	priv->irq_flags &= IRQF_TRIGGER_MASK;
Should be:
	priv->irq_flags = res_irq->flags & IRQF_TRIGGER_MASK;

I'm fixing this,

Marc
+	if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
+		priv->irq_flags |= IRQF_SHARED;
 	priv->reg_base = addr;
 	/* The CAN clock frequency is half the oscillator clock
frequency */
 	priv->can.clock.freq = pdata->osc_freq / 2;


note: patch is compile tested only.

Sven
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help