Thread (21 messages) 21 messages, 4 authors, 2012-06-28

Re: [PATCH 4/4] can: flexcan: add transceiver switch support when use device tree

From: Shawn Guo <hidden>
Date: 2012-06-27 11:22:06

On 27 June 2012 17:55, Hui Wang [off-list ref] wrote:
After read and compared with his patch:
1. Shawn use gpio_is_valid(gpio) instead of (gpio >= 0), it is good.
2. Shawn add a flag to record active level, it is good.
3. Shawn only add 1 gpio, this is not enough for imx6 sabre lite board.
4. Shawn forget to call gpio_release()
I'm about to resend my series to have linux-can copied and use
devm_gpio_request_one instead.  Do you want me to add STBY gpio
support into my patch?

Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help