Sounds like good change. I will re-submit a patch when I have a spare moment (probably next week).

REUBEN DOWLE | DESIGN ENGINEER | NAVICO AUCKLAND
 
Confidentiality Notice | This message may contain confidential and/or privileged information. If you are not the addressee or authorized to receive this for the addressee, you must not use, copy, disclose or take any action based on this message or any information herein. If you have received this message in error, please advise the sender immediately by reply e-mail and delete this message. Thank you for your cooperation

-----Original Message-----
From: Marc Kleine-Budde [mailto:mkl@pengutronix.de]
Sent: Wednesday, March 07, 2012 10:45 PM
To: Reuben Dowle
Cc: linux-can@vger.kernel.org
Subject: Re: [libsocketcan] Add can_get_link_stats() - v2

On 03/06/2012 08:04 PM, Reuben Dowle wrote:

quoted

Add can_get_link_stats()

This function gets link_stats64 information for the can interface.
This structure can be for any interface (not just can), but it seems
logical to keep functions for getting any statistics relevant to CAN
in this library.

Signed-off-by: Reuben Dowle <redacted>

I was at iCC2012 CAN conference, now I've some more time to look at the
code. What about naming the function after the struct? Seems more
consistent to me.

quoted

+int can_get_link_stats(const char *name, struct rtnl_link_stats64
+*ls)

I mean "can_get_link_stats64" instead of "can_get_link_stats"?

Marc

--
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |