Thread (13 messages) 13 messages, 5 authors, 2012-01-20

Re: [PATCH 2/3 V3.1] can/usb: PEAK-System Technik PCAN-USB specific part

From: Wolfgang Grandegger <hidden>
Date: 2012-01-20 17:32:18

Hi Stephane,

On 01/20/2012 03:53 PM, Stephane Grosjean wrote:
Hi,

Found time to answer to all of you:

- first, thanks for your review and tests
- next, I did a new version of the driver which fixes Alan's issue about
the variables in the stack, and which is *very* much less verbose too.
- the driver itself sets now the can state according to some usb adapter
events

When unplugging the can cable, candump displays now:

  can4  20000004  [8] 00 30 00 00 00 00 00 00   ERRORFRAME
        controller-problem{rx-error-passive,tx-error-passive}
  can4  20000004  [8] 00 30 00 00 00 00 00 00   ERRORFRAME
        controller-problem{rx-error-passive,tx-error-passive}
  can4  20000004  [8] 00 30 00 00 00 00 00 00   ERRORFRAME
        controller-problem{rx-error-passive,tx-error-passive}
  can4  20000004  [8] 00 30 00 00 00 00 00 00   ERRORFRAME
        controller-problem{rx-error-passive,tx-error-passive}
...
Does the device report state change to error *warning* as well? Also,
the state change to error passive should only be reported *once*. Well,
it's state change. I don't known what the hardware is actually
reporting. If it does report the current state periodically, you need to
handle it accordingly.
BTW: are the error counters also availabe/readable?

Wolfgang.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help