Thread (10 messages) 10 messages, 2 authors, 2025-08-15

Re: [PATCH v4 1/3] btrfs: implement ref_tracker for delayed_nodes

From: David Sterba <hidden>
Date: 2025-08-15 22:57:45

On Wed, Aug 13, 2025 at 10:41:15AM -0700, Leo Martins wrote:
On Wed, 13 Aug 2025 14:50:52 +0200 David Sterba [off-list ref] wrote:
quoted
On Tue, Aug 12, 2025 at 04:04:39PM -0700, Leo Martins wrote:
quoted
quoted
 config BTRFS_DEBUG
 	bool "Btrfs debugging support"
-	depends on BTRFS_FS
+	depends on BTRFS_FS && STACKTRACE_SUPPORT
How does this work? If STACKTRACE_SUPPORT is not enabled then we can't
enable BTRFS_DEBUG?
That's correct, my understanding is that STACKTRACE_SUPPORT is something
configured by different architectures based on whether or not they
support stacktraces. Maybe it would be better to do something like

select REF_TRACKER if STACKTRACE_SUPPORT

so we can still use DEBUG on architectures that don't support stacktraces,
though I can't imagine they would be very relevant.
I think we should not tie debug config option to some arch-specific
option, so the conditional seems right.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help