Thread (7 messages) 7 messages, 3 authors, 2021-11-22

Re: [PATCH v5 0/3] Index free space entries on size

From: David Sterba <hidden>
Date: 2021-11-22 17:45:32

On Thu, Nov 18, 2021 at 04:33:13PM -0500, Josef Bacik wrote:
quoted hunk ↗ jump to hunk
v4->v5:
- Broke out the self tests into their own patch.
- Use the rb_add_cached() helper instead of yet again duplicating the rb tree
  insertion code.
--- Original email ---
Hello,

I noticed while digging into an xfstests hang that the bytes index stuff was a
little wonky when it came to bitmap entries.  If we change the ->bytes at all we
weren't re-arranging the bytes indexed tree for bitmaps, because we don't do the
unlink/link thing that we do with extent entries.

I fixed this particular shortcoming and added a new set of selftests to validate
that everything was working as expected.  This uncovered a weirdness with how we
handle ->max_extent_size, so I've added that as a separate patch to make it
clear why the change is necessary.

Additionally I've updated my original patch to include the fixes necessary to
make bitmaps re-index when they change.  I've added self tests to validate the
changes to make sure everything is acting as we expect.  Thanks,

Josef

Josef Bacik (3):
  btrfs: only use ->max_extent_size if it is set in the bitmap
  btrfs: index free space entries on size
  btrfs: add self test for bytes_index free space cache
Added to misc-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help