Re: [PATCH v4 2/4] btrfs: expose chunk size in sysfs.
From: Nikolay Borisov <hidden>
Date: 2021-11-05 09:27:06
On 29.10.21 г. 21:39, Stefan Roesch wrote:
quoted hunk ↗ jump to hunk
This adds a new sysfs entry in /sys/fs/btrfs/<uuid>/allocation/<block type>/chunk_size. This allows to query the chunk size and also set the chunk size. Signed-off-by: Stefan Roesch <redacted> --- fs/btrfs/sysfs.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+)diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index f9eff3b0f77c..3b0bcbc2ed2e 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c@@ -21,6 +21,7 @@ #include "space-info.h" #include "block-group.h" #include "qgroup.h" +#include "misc.h" /* * Structure name Path@@ -92,6 +93,7 @@ static struct btrfs_feature_attr btrfs_attr_features_##_name = { \ static inline struct btrfs_fs_info *to_fs_info(struct kobject *kobj); static inline struct btrfs_fs_devices *to_fs_devs(struct kobject *kobj); +static inline struct kobject *get_btrfs_kobj(struct kobject *kobj); static struct btrfs_feature_attr *to_btrfs_feature_attr(struct kobj_attribute *a) {@@ -708,6 +710,67 @@ static ssize_t btrfs_space_info_show_##field(struct kobject *kobj, \ } \ BTRFS_ATTR(space_info, field, btrfs_space_info_show_##field) +/* + * Return space info chunk size. + */ +static ssize_t btrfs_chunk_size_show(struct kobject *kobj, + struct kobj_attribute *a, char *buf) +{ + struct btrfs_space_info *sinfo = to_space_info(kobj); + + return btrfs_show_u64(&sinfo->default_chunk_size, &sinfo->lock, buf); +} + +/* + * Store new user supplied chunk size in space info. + * + * Note: If the new chunk size value is larger than 10% of free space it is + * reduced to match that limit. + */ +static ssize_t btrfs_chunk_size_store(struct kobject *kobj, + struct kobj_attribute *a, + const char *buf, size_t len) +{ + struct btrfs_space_info *space_info = to_space_info(kobj); + struct btrfs_fs_info *fs_info = to_fs_info(get_btrfs_kobj(kobj)); + u64 val; + int ret; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + if (!fs_info) { + pr_err("couldn't get fs_info\n"); + return -EPERM; + } + + if (sb_rdonly(fs_info->sb)) + return -EROFS; + + if (!fs_info->fs_devices) + return -EINVAL; + + if (btrfs_is_zoned(fs_info)) + return -EINVAL; + + if (!space_info) { + btrfs_err(fs_info, "couldn't get space_info\n"); + return -EPERM; + } + + ret = kstrtoull(buf, 10, &val); + if (ret) + return ret; + + /* + * Limit stripe size to 10% of available space. + */ + val = min(div_factor(fs_info->fs_devices->total_rw_bytes, 1), val); + btrfs_update_space_info_chunk_size(space_info, space_info->flags, val);
I wonder if we need to enforce some sort of alignment i.e 128/256m otherwise we give the user to give all kinds of funky byte sizes? <snip>