Thread (13 messages) 13 messages, 2 authors, 2021-12-07

Re: [PATCH v2 1/2] btrfs: sysfs convert scnprintf and snprintf to use sysfs_emit

From: Anand Jain <hidden>
Date: 2021-10-21 16:27:35


On 22/10/2021 00:19, David Sterba wrote:
On Thu, Oct 21, 2021 at 11:31:16PM +0800, Anand Jain wrote:
quoted
commit 2efc459d06f1 (sysfs: Add sysfs_emit and sysfs_emit_at to format
sysfs out)
Please use the common formatting which is 2efc459d06f1 ("sysfs: Add
sysfs_emit and sysfs_emit_at to format sysfs output") in this case.
  Err. My bad. You told me that before. But, for some reason the related
  config isn't working. So I am doing it manually. I am going to try
  the config again.

quoted
merged in 5.10 introduced two new functions sysfs_emit() and
sysfs_emit_at() which are aware of the PAGE_SIZE max_limit of the buf.

Use the above two new functions instead of scnprintf() and snprintf()
in various sysfs show().

Signed-off-by: Anand Jain <redacted>
Reported-by: kernel test robot <redacted>
Reported-by should be used only for when the patch is fixing something
based on that report.
  Right. Ok.
I've applied the patch over the local version 1 but I don't see any
fix related to the the crash report, is that correct?
  Right. There is no crash report for the v1.

Thanks, Anand

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help