Re: [PATCH] btrfs-progs: print-tree: fix chunk/block group flags output

On Wed, Oct 13, 2021 at 07:53:48AM +0800, Qu Wenruo wrote:

quoted

quoted

See, if we hit SINGLE profile, we won't populate @profile array.

Fair enough, I had misread the != 0 check ... However, I'm wondering,
since this is only used during output, why don't we, for the sake of
consistency, output SINGLE, despite not having an exclusive bit for it?
The point of the human readable output is to be useful for users, so
instead of me having to know an implementation detail that SINGLE is not
represented by any bit, it will be much more useful if I see that
something is single profile, no ?

On the other hand, this breaks the consistency of flags output.

We only output flags we have on-disk.

Showing another flag which doesn't have on-disk bit can also be 
confusing, and break the existing output format.

Agreed, the dump utility should print only what is on-disk.