Re: [PATCH v2 2/2] btrfs-progs: misc-tests: add test case for receive --clone-fallback
From: Filipe Manana <hidden>
Date: 2021-09-30 12:53:43
On Thu, Sep 30, 2021 at 12:51 PM Qu Wenruo [off-list ref] wrote:
The new test case will create two send streams: - parent_stream A full send stream. Contains one file, as clone source. - clone_stream An incremental send stream. Contains one clone operation. Then we will receive the parent_stream with default mount options, while try to receive the clone_stream with nodatasum mount option. This should result clone failure due to nodatasum flag mismatch. Then check if the receive can continue with --clone-fallback option. Signed-off-by: Qu Wenruo <redacted>
Reviewed-by: Filipe Manana <redacted> Looks good, thanks.
quoted hunk ↗ jump to hunk
--- tests/common | 9 +++ .../049-receive-clone-fallback/test.sh | 58 +++++++++++++++++++ 2 files changed, 67 insertions(+) create mode 100755 tests/misc-tests/049-receive-clone-fallback/test.shdiff --git a/tests/common b/tests/common index 253071025db2..0423af4231a8 100644 --- a/tests/common +++ b/tests/common@@ -633,6 +633,15 @@ run_check_mount_test_dev() run_check $SUDO_HELPER mount -t btrfs $loop_opt "$@" "$TEST_DEV" "$TEST_MNT" } +run_check_remount_test_dev() +{ + setup_root_helper + + local opts="$1" + + run_check $SUDO_HELPER mount -o "remount,$opts" "$TEST_MNT" +} + # $1-$n: optional paths to unmount, otherwise fallback to TEST_DEV run_check_umount_test_dev() {diff --git a/tests/misc-tests/049-receive-clone-fallback/test.sh b/tests/misc-tests/049-receive-clone-fallback/test.sh new file mode 100755 index 000000000000..18136a9e63ee --- /dev/null +++ b/tests/misc-tests/049-receive-clone-fallback/test.sh@@ -0,0 +1,58 @@ +#!/bin/bash +# Verify that btrfs receive can fallback to buffered copy when clone +# failed + +source "$TEST_TOP/common" + +check_prereq mkfs.btrfs +check_prereq btrfs +setup_root_helper +prepare_test_dev + +tmp=$(mktemp -d --tmpdir btrfs-progs-send-stream.XXXXXX) + +# Create two sends stream, one as the parent and the other as an incremental +# stream with one clone operation. +run_check_mkfs_test_dev +run_check_mount_test_dev -o datacow,datasum +run_check $SUDO_HELPER "$TOP/btrfs" subvolume create "$TEST_MNT/subv" +run_check $SUDO_HELPER dd if=/dev/zero bs=1M count=1 of="$TEST_MNT/subv/file1" +run_check $SUDO_HELPER "$TOP/btrfs" subvolume snapshot -r "$TEST_MNT/subv" \ + "$TEST_MNT/snap1" +run_check $SUDO_HELPER cp --reflink=always "$TEST_MNT/subv/file1" \ + "$TEST_MNT/subv/file2" +run_check $SUDO_HELPER "$TOP/btrfs" subvolume snapshot -r "$TEST_MNT/subv" \ + "$TEST_MNT/snap2" + +run_check $SUDO_HELPER "$TOP/btrfs" send -f "$tmp/parent_stream" \ + "$TEST_MNT/snap1" +run_check $SUDO_HELPER "$TOP/btrfs" send -f "$tmp/clone_stream" \ + -p "$TEST_MNT/snap1" "$TEST_MNT/snap2" + +run_check_umount_test_dev +run_check_mkfs_test_dev + +# Receive the first stream with the same mount option +run_check_mount_test_dev -o datacow -o datasum + +# Receiving the full stream should not fail +run_check $SUDO_HELPER "$TOP/btrfs" receive -f "$tmp/parent_stream" "$TEST_MNT" + +# Remount the fs with nodatasum mount option, so that the new file received +# through the incremental stream will end up with the nodatasum flag set. +run_check_remount_test_dev nodatasum + +# Receiving incremental send stream without --clone-fallback should fail. +# As the clone source and destination have different NODATASUM flags +run_mustfail "receiving clone with different NODATASUM should fail" \ + $SUDO_HELPER "$TOP/btrfs" receive -f "$tmp/clone_stream" "$TEST_MNT" + +# Firstly we need to cleanup the partially received subvolume +run_check $SUDO_HELPER "$TOP/btrfs" subvolume delete "$TEST_MNT/snap2" + +# With --clone-fallback specified, the receive should finish without problem +run_check $SUDO_HELPER "$TOP/btrfs" receive --clone-fallback \ + -f "$tmp/clone_stream" "$TEST_MNT" +run_check_umount_test_dev + +rm -rf -- "$tmp" --2.33.0
-- Filipe David Manana, “Whether you think you can, or you think you can't — you're right.”