On 2021/9/20 18:43, David Sterba wrote:

On Wed, Sep 08, 2021 at 10:05:41AM +0800, Qu Wenruo wrote:

quoted

There is a bug in reddit (well, really the last place I expect to see
bug reports)

Why? People discuss things where they're used to, reddit is one of them
and from what I've seen there are good questions or usage recommendations.
Some of that goes to documentation or helps to tune usability.

Well, I'm more used to see memes/trolls there, maybe it's per-subreddit.

Anyway next time I would drop the prejudice.

Thanks,
Qu

quoted

that btrfstune -u fails due to transid error, but it also
leaves CHANGING_FSID flag to the super block, prevent btrfs-check to
properly check the fs.

The problem is, all commands in btrfs-progs can ignore transid error,
but there are only very limited usage of such ability.

Btrfstune definitely should not utilize this feature.

This patchset will introduce a new open ctree flag to explicitly
indicate we want to ignore transid errors.

Currently only there are only 3 tools using this feature:

- btrfs-check
   It may fix transid error (at least for the specific test case)

- btrfs-restore
   It wants to ignore all errors.

- btrfs-image
   To make fsck/002 happy.

Also add a test case for btrfstune, to make sure btrfstune can rejects
the fs when an obvious transid mismatch is detected during open_ctree().

Qu Wenruo (2):
   btrfs-progs: introduce OPEN_CTREE_ALLOW_TRANSID_MISMATCH flag
   btrfs-progs: misc-tests: add new test case to make sure btrfstune
     rejects corrupted fs

Added to devel, thanks.