Re: [PATCH v2 1/2] btrfs-progs: fi show: Print missing device for a mounted file system
From: Johannes Thumshirn <hidden>
Date: 2021-09-10 09:15:50
From: Johannes Thumshirn <hidden>
Date: 2021-09-10 09:15:50
On 10/09/2021 10:33, Nikolay Borisov wrote:
Currently when a device is missing for a mounted filesystem the output that is produced is unhelpful: Label: none uuid: 139ef309-021f-4b98-a3a8-ce230a83b1e2 Total devices 2 FS bytes used 128.00KiB devid 1 size 5.00GiB used 1.26GiB path /dev/loop0 *** Some devices missing While the context which prints this is perfectly capable of showing which device exactly is missing, like so: Label: none uuid: 4a85a40b-9b79-4bde-8e52-c65a550a176b Total devices 2 FS bytes used 128.00KiB devid 1 size 5.00GiB used 1.26GiB path /dev/loop0 devid 2 size 0 used 0 path /dev/loop1 MISSING This is a lot more usable output as it presents the user with the id of the missing device and its path. Signed-off-by: Nikolay Borisov <redacted> ---
Looks good, Reviewed-by: Johannes Thumshirn <redacted> but I think this also needs a patch for xfstests adjusting the filters.