Re: [PATCH 3/6] btrfs: zoned: use regular writes for relocation
From: Naohiro Aota <Naohiro.Aota@wdc.com>
Date: 2021-09-07 11:39:21
On Fri, Sep 03, 2021 at 11:44:44PM +0900, Johannes Thumshirn wrote:
quoted hunk ↗ jump to hunk
Now that we have a dedicated block group for relocation, we can use REQ_OP_WRITE instead of REQ_OP_ZONE_APPEND for writing out the data on relocation. Signed-off-by: Johannes Thumshirn <redacted> --- fs/btrfs/zoned.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c index 28a06c2d80ad..be82823c9b16 100644 --- a/fs/btrfs/zoned.c +++ b/fs/btrfs/zoned.c@@ -1490,6 +1490,9 @@ bool btrfs_use_zone_append(struct btrfs_inode *inode, u64 start) if (!is_data_inode(&inode->vfs_inode)) return false; + if (btrfs_is_data_reloc_root(inode->root)) + return false; +
Not using zone append for data relocation is not straight forward. So, I'd like to have a comment why we need to use WRITE here. Apart from that looks good, Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
cache = btrfs_lookup_block_group(fs_info, start); ASSERT(cache); if (!cache) -- 2.32.0