Thread (15 messages) 15 messages, 3 authors, 2021-08-23

Re: [PATCH RFC 2/3] btrfs: consolidate device_list_mutex in prepare_sprout to its parent

From: Su Yue <hidden>
Date: 2021-08-21 15:01:28

On Sat 21 Aug 2021 at 22:57, Su Yue [off-list ref] wrote:
On Fri 20 Aug 2021 at 16:53, Anand Jain [off-list ref]
wrote:
quoted
quoted
quoted
@@ -2366,6 +2366,8 @@ static int btrfs_prepare_sprout(struct
btrfs_fs_info *fs_info)
     u64 super_flags;

     lockdep_assert_held(&uuid_mutex);
+    lockdep_assert_held(&fs_devices->device_list_mutex);
+
Just a reminder: clone_fs_devices() still takes the mutex in
misc-next.
   As I am checking clone_fs_devices() does not take any lock.
  Could you pls recheck?
Hmmmm... misc-next:

https://github.com/kdave/btrfs-devel/blob/e05983195f31374ad51a0f3712efec381397f3cb/fs/btrfs/volumes.c#L381
Sorry, it should be

https://github.com/kdave/btrfs-devel/blob/misc-next/fs/btrfs/volumes.c#L995

--
Su
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help