Thread (5 messages) 5 messages, 3 authors, 2021-08-01

Re: [PATCH] fstests: generic/204: fail if the mkfs fails

From: Eryu Guan <hidden>
Date: 2021-08-01 12:53:40
Also in: fstests

On Sun, Aug 01, 2021 at 08:42:02PM +0800, Eryu Guan wrote:
On Thu, Jul 29, 2021 at 04:35:53PM -0400, Josef Bacik wrote:
quoted
My nightly fstests runs on my Raspberry Pi got stuck trying to run
generic/204.  This boiled down to mkfs failing to make the scratch
device that small with the subpage blocksize support, and thus trying to
fill a 1tib drive with tiny files.  On one hand I'd like to make
So the underlying disk is 1TB in size, and we ended up using this 1T
filesystem when _scratch_mkfs_sized failed?

But we have done _try_wipe_scratch_devs before each test to make sure we
don't use previous scratch dev accidently (just like this case), and the
subsesquent _scratch_mount will fail and fail the whole test. So it's
not clear to me what caused the failure you hit.
Ah, if the previous test _notrun'd, then the scratch dev didn't get
wiped. I think patch "check: don't leave the scratch filesystem mounted
after _notrun" from Darrick should fix the bug for you. Would you please
confirm?

Thanks,
Eryu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help