On Wed, Jul 21, 2021 at 03:37:03PM +0300, Nikolay Borisov wrote:

On 20.07.21 г. 21:02, Marcos Paulo de Souza wrote:

quoted

Using a transaction in btrfs_search_slot is only useful when if are
searching to add or modify the tree. When the function is only used for
searching, insert length and mod arguments are 0, there is no need to
use a transaction.

No functional changes, changing for consistency.

Signed-off-by: Marcos Paulo de Souza <redacted>

Basically when cow is 0 and ins_len is also 0 then no paths which
utilize a transaction are called so this patch is fine.

This sounds like a recipe for an assertion.