Thread (28 messages) 28 messages, 7 authors, 2021-07-23

Re: [PATCH RFC] fstests: allow running custom hooks

From: "Theodore Y. Ts'o" <tytso@mit.edu>
Date: 2021-07-20 02:08:18
Also in: fstests

On Tue, Jul 20, 2021 at 06:06:00AM +0800, Qu Wenruo wrote:
I can enhance the next version to do that, but that also means any error
inside the hook will bring down the whole test run.
I don't see why that would be?  We just have to sample the exit status
of the hook script, and if it matches a specific value, we skip the
test.  If the hook script crashes, the exit status will be some other
value, e.g., 128+<signal_number>, 127 if the script doesn't exist, 126
if the script exists but is not executable, etc.  So we just sample $?
and if it is, say, 83 (ascii 'S') we skip the test; otherwise, we run
the test.  How would an error inside the hook "bring down the whole
test run"?

Cheers,

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help