Re: [PATCH] btrfs-progs: Correct check_running_fs_exclop() return value
From: David Sterba <hidden>
Date: 2021-07-01 19:23:58
From: David Sterba <hidden>
Date: 2021-07-01 19:23:58
On Mon, Jun 28, 2021 at 02:40:00PM -0500, Goldwyn Rodrigues wrote:
check_running_fs_exclop() can return 1 when exclop is changed to "none" The ret is set by the return value of the select() operation. Checking the exclusive op changes just the exclop variable while ret is still set to 1. Set ret = 0 if exclop is set to BTRFS_EXCL_NONE or BTRFS_EXCL_UNKNOWN. Remove unnecessary continue statement at the end of the block.
That's describing what the code does in words, but there must be some user visible effects like failed command. Do you have some reproducer? I've applied patch as it's a fix but would still like to update the changelog.