Thread (17 messages) 17 messages, 4 authors, 2021-07-21

Re: [PATCH v3 8/9] 9p: migrate from sync_inode to filemap_fdatawrite_wbc

From: David Sterba <hidden>
Date: 2021-07-21 11:33:16
Also in: linux-fsdevel

I don't see any 9p people in CC, adding them. The cover letter is
https://lore.kernel.org/linux-btrfs/cover.1626288241.git.josef@toxicpanda.com/ (local)

On Wed, Jul 14, 2021 at 02:47:24PM -0400, Josef Bacik wrote:
quoted hunk ↗ jump to hunk
We're going to remove sync_inode, so migrate to filemap_fdatawrite_wbc
instead.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 fs/9p/vfs_file.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 59c32c9b799f..6b64e8391f30 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -625,12 +625,7 @@ static void v9fs_mmap_vm_close(struct vm_area_struct *vma)
 	p9_debug(P9_DEBUG_VFS, "9p VMA close, %p, flushing", vma);
 
 	inode = file_inode(vma->vm_file);
-
-	if (!mapping_can_writeback(inode->i_mapping))
-		wbc.nr_to_write = 0;
-
-	might_sleep();
-	sync_inode(inode, &wbc);
+	filemap_fdatawrite_wbc(inode->i_mapping, &wbc);
 }
 
 
-- 
2.26.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help