Re: [PATCH 4/4] btrfs: use the filemap_fdatawrite_wbc helper for delalloc shrinking
From: Nikolay Borisov <hidden>
Date: 2021-06-14 10:59:10
On 11.06.21 г. 16:54, Josef Bacik wrote:
sync_inode() has some holes that can cause problems if we're under heavy ENOSPC pressure. If there's writeback running on a separate thread sync_inode() will skip writing the inode altogether. What we really want is to make sure writeback has been started on all the pages to make sure we can see the ordered extents and wait on them if appropriate. Switch to this new helper which will allow us to accomplish this and avoid ENOSPC'ing early. Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Nikolay Borisov <redacted>
quoted hunk ↗ jump to hunk
--- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index c37271df2c6d..93d113991e2c 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c@@ -9680,7 +9680,7 @@ static int start_delalloc_inodes(struct btrfs_root *root, btrfs_queue_work(root->fs_info->flush_workers, &work->work); } else { - ret = sync_inode(inode, wbc); + ret = filemap_fdatawrite_wbc(inode->i_mapping, wbc); btrfs_add_delayed_iput(inode); if (ret || wbc->nr_to_write <= 0) goto out;