Thread (16 messages) 16 messages, 5 authors, 2021-06-10

Re: [PATCH] btrfs: sysfs: export dev stats in devinfo directory

From: David Sterba <hidden>
Date: 2021-06-09 15:17:44

On Wed, Jun 09, 2021 at 03:43:44PM +0800, Anand Jain wrote:
quoted
I'm more inclined to follow what
/proc/ stats do. It's more convenient to monitor stats in one file read
than having to do 'cat error_stats/*' or with filenames as 'grep ^
error_stats/*'.
  Agreed. I prefer one file from the convenience pov. Also, block dev has
  one file, the reason to represent it invariably at a given time [1]
    [1] https://www.kernel.org/doc/Documentation/block/stat.txt
  IMO the same applies to btrfs too.
Ah nice, same reason for us to use the file then. I'd argue that having
the names of the values is more convenient than just an array of raw
numbers though.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help